Fix spell targeting performance and prevent potential infinite loops … #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Seems good though mahj is maintaing mns now so do that on his fork probably |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In AoeSelector.java, canHit was optimized: Explosion.getSeenPercent was replaced with a bounded raycast to prevent SimpleProjectileEntity server hangs from expensive per-tick visibility checks. In ExpireAction.java, a guard was added to tryActivate to prevent recursive discard() calls during ON_EXPIRE activations, resolving mmorpg:spell_block_entity removal freezes. These changes address the identified performance bottlenecks and prevent Watchdog crashes.